Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(quickstart): tip for controller and config style #666

Merged
merged 1 commit into from
Mar 28, 2017
Merged

docs(quickstart): tip for controller and config style #666

merged 1 commit into from
Mar 28, 2017

Conversation

atian25
Copy link
Member

@atian25 atian25 commented Mar 28, 2017

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@atian25 atian25 requested a review from dead-horse March 28, 2017 03:45
@mention-bot
Copy link

@atian25, thanks for your PR! By analyzing the history of the files in this pull request, we identified @huacnlee, @pmq20 and @missjing to be potential reviewers.

@atian25 atian25 mentioned this pull request Mar 28, 2017
Closed
4 tasks
@codecov
Copy link

codecov bot commented Mar 28, 2017

Codecov Report

Merging #666 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #666   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          26     26           
  Lines         638    638           
=====================================
  Hits          638    638

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e47c24b...4487b28. Read the comment docs.

@popomore popomore merged commit 5f5cf91 into master Mar 28, 2017
@popomore popomore deleted the docs-simple-controller branch March 28, 2017 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dead-horse dead-horse dead-horse approved these changes

@popomore popomore popomore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atian25 @mention-bot @popomore @dead-horse